From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 13 Jul 2014 17:10:27 GMT
Subject: Re: [PATCH 3/3] tag: support configuring --sort via .gitconfig
Message-ID: <xmqqfvi518xo.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CAPig+cR9VCtNhk-FbqDM1LTCa8VeUTYXU4XEX36Rb5CxPFfLWQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

>> Made parse_sort_string take a "var" parameter, and if given will only warn
>> about invalid parameter, instead of error.
>
> This seems unnecessarily ugly since it's hard-coding specialized
> knowledge of the callers' error-reporting requirements into what
> should be a generalized parsing function. If you instead make
> parse_sort_string() responsible only for attempting to parse the
> value, but leave error-reporting to the callers, then this ugliness
> goes away. See below.

Yup, you are absolutely right.  Thanks for catching my silly.