From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 09 Nov 2014 16:45:59 GMT
Subject: Re: [PATCH 4/5] trailer: reuse ignore_non_trailer() to ignore conflict lines
Message-ID: <xmqqfvdse308.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20141109.113509.1363113947439404678.chriscool@tuxfamily.org>

Christian Couder <chriscool@tuxfamily.org> writes:

> Yeah, it won't be as efficient as using only one strbuf and only byte
> oriented functions, and it looks much less manly too :-) But over time in
> Git we have developed a number of less efficient but quite clean
> abstractions like strbuf, argv_array, sha1_array and so on, that we
> are quite happy with.

Actually, all these examples you gave are fairly efficient and clean
abstractions.  I find it insulting to pretend that the "one line per
strbuf" is in the same league.  It isn't.

And it is not about manliness.