From: Junio C Hamano Date: Mon, 29 Jun 2015 19:11:14 GMT Subject: Re: [PATCH v5 0/7] refs backend preamble Message-ID: In-Reply-To: <1435600468-21710-1-git-send-email-dturner@twopensource.com> There might be other issues but from cursory read, at least the following needs to be split and squashed into patches that introduce them. Otherwise, it was a very pleasant read. Thanks. Documentation/git-reflog.txt | 4 ++-- builtin/reflog.c | 2 +- refs.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/git-reflog.txt b/Documentation/git-reflog.txt index 7ab2c42..2bf8aa6 100644 --- a/Documentation/git-reflog.txt +++ b/Documentation/git-reflog.txt @@ -23,8 +23,8 @@ depending on the subcommand: [--dry-run] [--verbose] [--all | ...] 'git reflog delete' [--rewrite] [--updateref] [--dry-run] [--verbose] ref@\{specifier\}... -'git reflog create ... -'git reflog exists +'git reflog create' ... +'git reflog exists' Reference logs, or "reflogs", record when the tips of branches and other references were updated in the local repository. Reflogs are diff --git a/builtin/reflog.c b/builtin/reflog.c index 1ecbfb6..3080865 100644 --- a/builtin/reflog.c +++ b/builtin/reflog.c @@ -742,7 +742,7 @@ static int cmd_reflog_create(int argc, const char **argv, const char *prefix) static int cmd_reflog_exists(int argc, const char **argv, const char *prefix) { - int i, status = 0, start = 0; + int i, start = 0; for (i = 1; i < argc; i++) { const char *arg = argv[i]; diff --git a/refs.c b/refs.c index 55235cf..831d31c 100644 --- a/refs.c +++ b/refs.c @@ -2911,7 +2911,7 @@ static int rename_ref_available(const char *oldname, const char *newname) } static int write_ref_to_lockfile(struct ref_lock *lock, - const unsigned char *sha1, struct strbuf* err); + const unsigned char *sha1, struct strbuf *err); static int commit_ref_update(struct ref_lock *lock, const unsigned char *sha1, const char *logmsg, struct strbuf *err); -- 2.5.0-rc0-169-ge0d9173