From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Jul 2015 20:00:08 GMT
Subject: Re: [PATCH 3/7] pack-protocol.txt: Mark all LFs in push-cert as required
Message-ID: <xmqqfv578x87.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1435774099-21260-4-git-send-email-dborowitz@google.com>

Dave Borowitz <dborowitz@google.com> writes:

> Signed-off-by: Dave Borowitz <dborowitz@google.com>
> ---
>  Documentation/technical/pack-protocol.txt | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/technical/pack-protocol.txt
> b/Documentation/technical/pack-protocol.txt
> index 1386840..2d8b1a1 100644
> --- a/Documentation/technical/pack-protocol.txt
> +++ b/Documentation/technical/pack-protocol.txt
> @@ -534,6 +534,9 @@ A push certificate begins with a set of header
> lines.  After the
>  header and an empty line, the protocol commands follow, one per
>  line.
>  
> +Note that (unlike other portions of the protocol), all LFs in the
> +`push-cert` specification above MUST be present.
> +
>  Currently, the following header fields are defined:
>  
>  `pusher` ident::

I am moderately negative about this; wouldn't it make the end result
cleaner to fix the implementation?