From: Junio C Hamano Date: Wed, 07 Oct 2015 17:36:01 GMT Subject: Re: [PATCH] pretend_sha1_file(): Change return type from int to void Message-ID: In-Reply-To: Johannes Schindelin writes: > As to the patch, I cannot speak for Junio, of course, but my > preference would be to keep the return type. Traditionally, functions > that can fail either die() or return an int; non-zero indicates an > error. In this case, it seems that we do not have any condition > (yet...) under which an error could occur. It does not seem very > unlikely that we may eventually have such conditions, though, hence my > preference. Accepting Tobias's patch may have a documentation value to let the callers know that the function does not give the caller any error diagnosis, and it may matter a lot if this were a very frequently used function, but that is not exactly the case here. I do not care too deeply.