From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 21 Apr 2016 23:20:07 GMT
Subject: Re: What's cooking in git.git (Apr 2016, #06; Thu, 21)
Message-ID: <xmqqfuuer1lk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160421225116.GF1096@LykOS>

Santiago Torres <santiago@nyu.edu> writes:

> On Thu, Apr 21, 2016 at 03:20:39PM -0700, Junio C Hamano wrote:
>> * st/verify-tag (2016-04-19) 6 commits
>>  - tag -v: verfy directly rather than exec-ing verify-tag
>>  - verify-tag: move tag verification code to tag.c
>>  - verify-tag: prepare verify_tag for libification
>>  - verify-tag: update variable name and type
>>  - t7030: test verifying multiple tags
>>  - builtin/verify-tag.c: ignore SIGPIPE in gpg-interface
>> 
>>  Unify internal logic between "git tag -v" and "git verify-tag"
>>  commands by making one directly call into the other.
>> 
>>  Will merge to 'next'.
>
> Hi Junio, 
>
> Ramsay Jones[1] Suggested we dropped the extern qualifier on the
> declaration of verify-tag() in tag.c as it is causing a warning with
> sparse.
>
> Should I re-roll this before it's merged into next?

Yes please.