From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 01 Jul 2016 20:01:48 GMT
Subject: Re: [PATCH v4] Refactor recv_sideband()
Message-ID: <xmqqfurtxh3n.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <146726738438.11587.1114281440699318943@s-8d3a3869.on.site.uni-stuttgart.de>

Lukas Fleischer <lfleischer@lfos.de> writes:

> Oh, and one more detail: I wonder why we still use fwrite(), now that we
> know we can use xwrite() which guarantees atomicity. Is there a reason
> for that?

The code (before squashing anyway) used to use fprintf() directly
bypasing the outbuf for unusual cases, and we didn't want to mix raw
file descriptor access with stdio access.

That no longer is the case, so I think we can switch to xwrite(),
and lose the last paragraph of the log message entirely.

Thanks.