From: Junio C Hamano Date: Tue, 15 Aug 2017 18:58:11 GMT Subject: Re: [PATCH v3 1/2 / RFC] builtin/branch: stop supporting the use of --set-upstream option Message-ID: In-Reply-To: <772aaebf-81ea-ac22-9d2f-35d0778f502f@gmail.com> Kaartic Sivaraam writes: > 1. Duplicate the check done in 'builtin/branch.c' in > 'builtin/checkout.c'. This doesn't > sound good to me. Doesn't sound good to me, either. Some refactoring to make it easier to reuse it from the new caller would be necessary.