From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Sep 2017 21:33:23 GMT
Subject: Re: [PATCH v2] config: avoid "write_in_full(fd, buf, len) < len" pattern
Message-ID: <xmqqfubq1dy4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170913182431.GE27425@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Jeff King wrote:
>
>> What I missed is that copy_begin and copy_end here are actually size_t
>> variables, not the pointers. Sorry for the confusion, and here's an
>> updated version of the patch with this paragraph amended (the patch
>> itself is identical):
>
> Subtle.  The world makes more sense now.  Thanks for figuring it out.
> ...
> For what it's worth,
> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks, both. It seems that I missed all the fun ;-)