From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 01 Nov 2017 06:23:28 GMT
Subject: Re: [PATCH v3 0/8] convert diff flags to be stored in a struct
Message-ID: <xmqqfu9ytt3z.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171031181911.42687-1-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

> Changes in v3:
>  * Now always pass struct diff_flags by reference and don't return the struct
>    but rather modify the passed in struct.
>  * Don't clear TEXTCONV_SET_VIA_CMDLINE when --no-textconv is passed
>  * added additional patches (set out separately before) to remove the macros
>    and change the struct members to lowercase

The result looks pleasant overall, although I suspect I'd need some
time to get used to them being all explicit bitfields.

Queued.