From: Junio C Hamano Date: Mon, 05 Mar 2018 21:50:32 GMT Subject: Re: [PATCH v9 6/8] convert: check for detectable errors in UTF encodings Message-ID: In-Reply-To: <20180304201418.60958-7-lars.schneider@autodesk.com> lars.schneider@autodesk.com writes: > +static int validate_encoding(const char *path, const char *enc, > + const char *data, size_t len, int die_on_error) > +{ > + if (!memcmp("UTF-", enc, 4)) { Does the caller already know that enc is sufficiently long that using memcmp is safe?