From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Oct 2018 00:39:33 GMT
Subject: Re: [PATCH v4 10/12] Add a base implementation of SHA-256 support
Message-ID: <xmqqftwpa8my.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20181028155206.GI6119@genre.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

>> > +
>> > +#include "git-compat-util.h"
>> 
>> this shouldn't be needed and might be discouraged as per the
>> instructions in Documentation/CodingGuidelines
>
> This may not strictly be needed, but removing it makes the header no
> longer self-contained, which blows up my (and others') in-editor
> linting.

That sounds like bending backwards to please tools, though.  Can't
these in-editor linting learn the local rules of the codebase they
are asked to operate on?