From: Junio C Hamano Date: Thu, 23 Jul 2020 01:41:33 GMT Subject: Re: [PATCH 2/4] upload-pack.c: allow banning certain object filter(s) Message-ID: In-Reply-To: <20200722201531.GA59352@syl.lan> Taylor Blau writes: >> If this die() were to show the same fancy error message as in the ERR >> packet, then it would always make it to 'git clone's stderr in the >> tests, so the tests could reliably check that 'git upload-pack' died >> for the expected reason. > > Beautiful idea. I changed this in my fork, and I'll send it to this > thread after 2.28 is out, since I don't want to create a distraction in > the meantime. Thanks. As long as everybody understands that "distraction" will immediately gets backburnered when a regression relevant to the upcoming release is found, however, I think performing work as usual is a good thing. After all, we often find glitches in the current code by trying to build on it, in addition to using it.