From: Junio C Hamano Date: Fri, 09 Oct 2020 21:12:59 GMT Subject: Re: [PATCH v4 2/2] commit-graph: don't write commit-graph when disabled Message-ID: In-Reply-To: <4439e8ae8fdc9abf28df29d3038a1483d9084cf2.1602276832.git.gitgitgadget@gmail.com> "Derrick Stolee via GitGitGadget" writes: > + if (!the_repository->settings.core_commit_graph) { > + warning(_("attempting to write a commit-graph, but 'core.commitGraph' is disabled")); > + return 0; > + } Makes sense. We probably would want to short-circuit invocation of commit-graph related tasks in the maintenance by checking the feature, if we are not already doing so. Thanks.