From: Junio C Hamano Date: Thu, 15 Oct 2020 19:13:53 GMT Subject: Re: [PATCH] fast-import: fix over-allocation of marks storage Message-ID: In-Reply-To: <20201015185853.GA1108210@coredump.intra.peff.net> Jeff King writes: > Looking over the thread, I don't see any problems pointed out (though > as your diff below shows, the original patch missed the re-ordering > required for the submodule mapping call). > > So I'd prefer my patch because of that fix and because of the tests. Oh, no question about that. I would take a fresh fix that was done on a more recent codebase than the one that was 4 months old and had to be rebased. Having a test too is a huge plus. Thanks. And by the way, thanks for the "-cooking -announce" tip ;-)