From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 15 Apr 2021 22:24:04 GMT
Subject: Re: [PATCH 15/16] Revert and amend "test-lib-functions: assert correct parameter count"
Message-ID: <xmqqfszrnq4b.fsf@gitster.g>
In-Reply-To: <20210415220526.GO2947267@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> ...  suppress '-x' output
> from test helper functions, and then this issue will become moot
> anyway.

That is certainly a better approach than tweaking each call site of
BUG.

The interface to BUG is "write a code to determine condition and
then die by calling BUG", which means under '-x' you are bound to
see the trace from "code to determine condition" part.

I wonder if introducing a BUG_ON helper function that

 - turns off '-x' trace upon entry;
 - takes a condition as one of its arguments and evals it;
 - issues a message and dies if needed;
 - otherwise arranges to turn '-x' trace on and return.

would solve it well?

Thanks.