From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 08 Jul 2021 22:21:53 GMT
Subject: Re: [PATCH v3 3/4] pack-objects.c: do stdin parsing via revision.c's API
Message-ID: <xmqqfswoa1ku.fsf@gitster.g>
In-Reply-To: <patch-3.4-943b1b4c12a-20210621T150651Z-avarab@gmail.com>

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Extend the rev_info stdin parsing API to support hooking into its
> read_revisions_from_stdin() function, and change the custom stdin
> parsing in pack-objects.c to use it.

This step, while it might not be introducing new bugs, does not look
anything more than just adding yet another new API for the sake of
adding one (especially, the number of lines added vs removed does
not look so impressive).

Perhaps we'll see why it makes sense in the next step?

>  builtin/pack-objects.c | 63 ++++++++++++++++++++----------------------
>  revision.c             | 22 +++++++++++++++
>  revision.h             | 30 ++++++++++++++++++++
>  3 files changed, 82 insertions(+), 33 deletions(-)