From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 08 Nov 2021 19:08:49 GMT
Subject: Re: [PATCH 2/3] vimdiff: add tool documentation
Message-ID: <xmqqfss6v51a.fsf@gitster.g>
In-Reply-To: <CAJDDKr4icrigRO-2S_HVdY7+W0EGJ8XBn5dD=O-qy1tXym4u8w@mail.gmail.com>

David Aguilar <davvid@gmail.com> writes:

>     (diff_mode && ... || merge_cmd_help ...) |
>     while IFS= read -r line
>     do
>        ...
>     done
>
> How come we have to unset IFS here?

We are taking the input into a single variable "line", so what are
we splitting with IFS anyway?

In any case, thanks for spotting bash-isms to avoid.  We started
allowing "local", I think, at least in the tests, but otherwise many
bash-only things like "<(process)" redirection and "${substring:4}"
substitution are simply no-no.