From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Nov 2021 23:28:47 GMT
Subject: Re: [PATCH v2 3/6] refs: allow skipping OID verification
Message-ID: <xmqqfsre4k40.fsf@gitster.g>
In-Reply-To: <93fe3f03fb2a10f36aff4a6e4702053daeaa1d64.1638211786.git.gitgitgadget@gmail.com>

"Han-Wen Nienhuys via GitGitGadget" <gitgitgadget@gmail.com> writes:

> +/*
> + * Blindly write an object_id. This is useful for testing data corruption
> + * scenarios.
> + */
> +#define REF_SKIP_OID_VERIFICATION (1 << 10)

That makes sense.  Readers would expect that this flag is passed
only from test-helper but not in the regular code, at least without
an option like "git update-ref --skip-oid-verification ..."?

After applying these 6 patches, I do not seem to find anybody who
actually flips this bit on.  Perhaps I missed a step or so?