From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 19 Aug 2022 21:33:58 GMT
Subject: Re: [PATCH 1/2] p0004: fix prereq declaration
Message-ID: <xmqqfshrkjeh.fsf@gitster.g>
In-Reply-To: <0e71792a718512089b94c0d5985db7fd8093c6a5.1660942149.git.gitgitgadget@gmail.com>

"Victoria Dye via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Victoria Dye <vdye@github.com>
>
> Fix multi-threaded 'p0004' test's use of the 'REPO_BIG_ENOUGH_FOR_MULTI'
> prerequisite. Unlike normal 't/' tests, 't/perf/' tests need to have their
> prerequisites declared with the '--prereq' flag.
>
> Signed-off-by: Victoria Dye <vdye@github.com>
> ---
>  t/perf/p0004-lazy-init-name-hash.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks.  It is unfortunate that we need to live with this seemingly
unnecessary deviation.

> diff --git a/t/perf/p0004-lazy-init-name-hash.sh b/t/perf/p0004-lazy-init-name-hash.sh
> index 1afc08fe7f1..85be14e4ddb 100755
> --- a/t/perf/p0004-lazy-init-name-hash.sh
> +++ b/t/perf/p0004-lazy-init-name-hash.sh
> @@ -49,7 +49,7 @@ test_perf "single-threaded, $desc" "
>  	test-tool lazy-init-name-hash --single --count=$count
>  "
>  
> -test_perf REPO_BIG_ENOUGH_FOR_MULTI "multi-threaded, $desc" "
> +test_perf "multi-threaded, $desc" --prereq REPO_BIG_ENOUGH_FOR_MULTI "
>  	test-tool lazy-init-name-hash --multi --count=$count
>  "