From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Apr 2023 21:33:14 GMT
Subject: Re: [PATCH v9 4/8] t2400: add tests to verify --quiet
Message-ID: <xmqqfs8yjisl.fsf@gitster.g>
In-Reply-To: <20230417093255.31079-5-jacobabel@nullpo.dev>

Jacob Abel <jacobabel@nullpo.dev> writes:

> +test_expect_success 'add --quiet -b' '
> +	test_when_finished "git branch -D quietnewbranch" &&
> +	test_when_finished "git worktree remove -f -f another-worktree" &&
> +	test_when_finished cat actual >&2 &&
> +	git worktree add --quiet -b quietnewbranch another-worktree 2>actual &&
> +	test_must_be_empty actual
> +'

It is good to test the --quiet option.  It is not good to have the
ineffective "cat actual" when test_must_be_empty is already used.
Probably the same comment applies to the rest of the patch.

Thanks.