From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 29 Apr 2024 19:24:46 GMT
Subject: Re: [PATCH v5 1/2] add-patch: do not show UI messages on stderr
Message-ID: <xmqqfrv4ug3l.fsf@gitster.g>
In-Reply-To: <10905ab3-bb3c-4669-9177-84c8e6759616@gmail.com>

Rubén Justo <rjusto@gmail.com> writes:

> diff --git a/add-patch.c b/add-patch.c
> index 0997d4af73..fc0eed4fd4 100644
> --- a/add-patch.c
> +++ b/add-patch.c
> @@ -293,10 +293,9 @@ static void err(struct add_p_state *s, const char *fmt, ...)
>  	va_list args;
>  
>  	va_start(args, fmt);
> -	fputs(s->s.error_color, stderr);
> -	vfprintf(stderr, fmt, args);
> -	fputs(s->s.reset_color, stderr);
> -	fputc('\n', stderr);
> +	fputs(s->s.error_color, stdout);
> +	vprintf(fmt, args);
> +	puts(s->s.reset_color);

I like the attention of the detail here ;-).