From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 07 Jun 2024 21:49:32 GMT
Subject: Re: [PATCH 1/2] commit-graph.c: remove temporary graph layers on exit
Message-ID: <xmqqfrtoe843.fsf@gitster.g>
In-Reply-To: <ZmN+crXyZOze122U@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

>> Before this rename, after the close(fd) we saw in the previous hunk,
>> there is one early error return when we fail to rename the base
>> graph file.  Do we need to do anything there, or an unfinished
>> tempfile getting removed at the process termination is sufficient
>> for cleaning up the mess?
>
> We could explicitly clean it up, but we'll do so implicitly upon exit,
> so I think it's fine to leave it as-is.

OK.  That sounds good.