From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 13 Jul 2026 16:10:20 GMT
Subject: Re: [PATCH 2/2] t1100: move creation of expected output into setup test
Message-ID: <xmqqfr1mzx8z.fsf@gitster.g>
In-Reply-To: <20260713140142.27898-3-diy2903@gmail.com>

Shlok Kulshreshtha <diy2903@gmail.com> writes:

> The "expected" file was created at the top level of the script, outside

Use the present tense to describe what the current code does.  For
example:

    The 'expected' file is created at the top-level of the script,
    outside ...

> of any test. Code that runs outside of a test is not protected by the
> test harness: a failure there is not reported as a test failure and is
> easy to miss.
>
> Move the here-doc that creates "expected" into the existing setup test
> ("test preparation: write empty tree"), using a "<<-" here-doc so its
> body can be indented along with the rest of the test.
>
> Signed-off-by: Shlok Kulshreshtha <diy2903@gmail.com>
> ---
>  t/t1100-commit-tree-options.sh | 15 +++++++--------
>  1 file changed, 7 insertions(+), 8 deletions(-)

Trivially correct.

Thanks.

>
> diff --git a/t/t1100-commit-tree-options.sh b/t/t1100-commit-tree-options.sh
> index fabe5a97cb..b434d1848e 100755
> --- a/t/t1100-commit-tree-options.sh
> +++ b/t/t1100-commit-tree-options.sh
> @@ -14,15 +14,14 @@ Also make sure that command line parser understands the normal
>  
>  . ./test-lib.sh
>  
> -cat >expected <<EOF
> -tree $EMPTY_TREE
> -author Author Name <author@email> 1117148400 +0000
> -committer Committer Name <committer@email> 1117150200 +0000
> -
> -comment text
> -EOF
> -
>  test_expect_success 'test preparation: write empty tree' '
> +	cat >expected <<-EOF &&
> +	tree $EMPTY_TREE
> +	author Author Name <author@email> 1117148400 +0000
> +	committer Committer Name <committer@email> 1117150200 +0000
> +
> +	comment text
> +	EOF
>  	git write-tree >treeid
>  '