From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Jan 2014 20:14:56 GMT
Subject: Re: [PATCH/RFC] Makefile: Fix compilation of windows resource file
Message-ID: <xmqqeh3zydrz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <xmqqppnjyl10.fsf@gitster.dls.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

> Johannes Sixt <j.sixt@viscovery.net> writes:
> ...
>> ..., I suggest that we just punt (as per
>> my patch). That should work out nicely because we can fairly safely assume
>> that there are no installers around that look at these particular version
>> numbers.

OK.  I do not think we care too deeply about how a "forced to be
four dewey-decimal numbers" looks compared to 2 or 3 numbers in the
$(GIT_VERSION), as I think we always had that (non-)issue, but not
being able to compile is not very nice.

So can you, Pat or Ramsay send a tested patch with a proposed log
message?   Preferrably by -rc1 but I think the change is low impact
that it can be in -rc2, leaving -rc1 broken.

Thanks.