From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 29 Aug 2014 21:56:18 GMT
Subject: Re: [PATCH 2/2] index-pack: handle duplicate base objects gracefully
Message-ID: <xmqqegvz3qpp.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140829205809.GB7060@peff.net>

Jeff King <peff@peff.net> writes:

> If a pack contains duplicates of an object, and if that
> object has any deltas pointing at it with REF_DELTA, we will
> try to resolve the deltas twice. While unusual, this is not
> strictly an error, but we currently die() with an unhelpful
> message.

Hmm, I vaguely recall Shawn declaring this as an error in the pack
stream, though.

> The duplicate base object is not our concern during the
> resolution phase, and the .idx-writing phase will decide
> whether to complain or allow it (based on whether --strict
> is set).

OK.  We still diagnose and just be more lenient without loosening
the correctness of the result, so that would be not just OK but a
very welcome change.

Will queue.  Thanks.