From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 08 Mar 2015 09:03:34 GMT
Subject: Re: [PATCH v3 2/3] sha1_file: implement changes for "cat-file --literally -t"
Message-ID: <xmqqegozsvx5.fsf@gitster.dls.corp.google.com>
In-Reply-To: <54FC0CCE.70009@gmail.com>

karthik nayak <karthik.188@gmail.com> writes:

> What parse_sha1_header() does to get the type is just find the first
> occurrence of a " " manually and store everything before it as the
> type. Then it finds the size of the object if needed. And finally
> returns the type by calling type_from_string(). This is where we get
> the undefined type error.

Yes, exactly.  The change illustrated in $gmane/264420 may be
incomplete and some calls from the sha1_object_info_extended() after
that change may still need to further be tweaked to pay attention to
LOOKUP_LITERALLY bit; for example, parse_sha1_header() may want to
learn not to barf when seeing an unexpected typename in the header
when the caller asks to look up "literally".

I thought I already said that; sorry if I forgot.