From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 May 2016 20:37:39 GMT
Subject: Re: [PATCH v2 3/5] t1500: avoid changing working directory outside of tests
Message-ID: <xmqqeg90v2ss.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160517193630.10379-4-sunshine@sunshineco.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> +			git ${dir:+-C "$dir"} rev-parse --$o >actual &&

This is kosher POSIX, but I vaguely recall some shells had trouble
with the SP between -C and "$dir" in the past.  Let's see if anybody
screams; hopefully I am misremembering or buggy shells died out.

Other than that, the entire series makes the script easier to grok.
Thanks.