From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Sep 2016 17:01:36 GMT
Subject: Re: [PATCH v2 07/14] i18n: merge-recursive: mark error messages for translation
Message-ID: <xmqqeg4p3vdb.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <882dcaf3-fd9b-0d83-2756-f3315dd6bb4e@gmail.com>

Jean-Noël Avila <avila.jn@gmail.com> writes:

> Le 12/09/2016 à 13:29, Vasco Almeida a écrit :
>> -			warning("Cannot handle more than %d bases. "
>> -				"Ignoring %s.",
>> +			warning(_("cannot handle more than %d bases. "
>> +				  "Ignoring %s."),
>>  				(int)ARRAY_SIZE(bases)-1, argv[i]);
>>  	}
>
> This one is also missing the plural form.

That is technically correct, but I do not think it matters, as we
won't be making bases[] array smaller than it currently is, so the
"more than %d bases" part of the message will always be in the
plural form and never be singular.

Thanks.