From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Sep 2016 23:31:07 GMT
Subject: Re: [PATCH v7 05/10] pkt-line: add packet_write_gently()
Message-ID: <xmqqeg4oy9tw.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160908182132.50788-6-larsxschneider@gmail.com>

larsxschneider@gmail.com writes:

> +int packet_write_gently(const int fd_out, const char *buf, size_t size)
> +{
> +	static char packet_write_buffer[LARGE_PACKET_MAX];
> +
> +	if (size > sizeof(packet_write_buffer) - 4) {
> +		error("packet write failed");
> +		return -1;
> +	}
> +	packet_trace(buf, size, 1);
> +	size += 4;
> +	set_packet_header(packet_write_buffer, size);
> +	memcpy(packet_write_buffer + 4, buf, size - 4);
> +	if (write_in_full(fd_out, packet_write_buffer, size) == size)
> +		return 0;
> +
> +	error("packet write failed");
> +	return -1;
> +}

The same comment as 4/10 applies here.