From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 07 Dec 2016 22:04:56 GMT
Subject: Re: [PATCH 00/17] pathspec cleanup
Message-ID: <xmqqeg1jwg3b.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1481061106-117775-1-git-send-email-bmwill@google.com>

Brandon Williams <bmwill@google.com> writes:

> The intent of this series is to cleanup some of the pathspec initialization
> code as well as finally migrating the remaining users of the _raw field or
> get_pathspec() to the pathspec struct interface.  This way both the _raw field
> and get_pathspec() can be removed from the codebase.  This also removes the
> functionality where parse_pathspec() modified the const char * argv array that
> was passed in (which felt kind of odd to me as I wouldn't have expected the
> passed in array to be modified).
>
> I also noticed that there are memory leaks associated with the 'original' and
> 'match' strings.  To fix this the pathspec struct needed to take ownership of
> the memory for these fields so that they can be cleaned up when clearing the
> pathspec struct.

Both good goals.  Thanks for working on this.