From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 17 Oct 2017 07:12:19 GMT
Subject: Re: [PATCH 0/3] Re: [PATCH] check-ref-format: require a repository for --branch
Message-ID: <xmqqefq2nt7w.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20171017070619.bdgvujmbw4uxvwle@aiede.mtv.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Handles the nongit case in strbuf_check_branch_ref instead of
> introducing a new check_branch_ref_format helper.

I view that as a regression, actually.  Don't we want a function
that does not require a strbuf when asking a simple question: "I
have a string, and I want to see if that is a valid name"?