From: Junio C Hamano Date: Wed, 27 Dec 2017 19:57:29 GMT Subject: Re: [PATCH] diffcore: add a filter to find a specific blob Message-ID: In-Reply-To: <20171227185907.GE149622@aiede.mtv.corp.google.com> Jonathan Nieder writes: > Stefan Beller wrote: >> On Thu, Dec 14, 2017 at 6:18 PM, Junio C Hamano wrote: > >>> I think it would make it a better companion to --pickaxe but we need >>> to align its behaviour a little bit so that it plays better with the >>> "--pickaxe-all" option, and also needs to hide mode and name only >>> changes just like pickaxe. >> >> I looked into this, and the small changes needed led me to thinking >> it could be integrated into the diffcore-pickaxe code completely, >> roughly like (spaces mangled): > > Nice, this looks promising. Indeed it is very simple, straight-forward and nice ;-) >> I disagree, as the user doesn't have the content, but the hash >> over the content only and wants to know more about it.... (correcting Stefan) The user can do "git cat-file blob $oid" to learn about the contents, so from end user's point of view, the "pickaxe with object ID" can be seen as merely a short-hand for git log -S"$(git cat-file blob $oid)" almost. But that is a tangent in this response. > Interesting --- I come to the opposite conclusion. > > The pickaxe-style behavior seems more consistent and simpler to > explain and better matches the use cases I can think of. Yeah, I am more leaning toward agreeing with you.