From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 30 Mar 2018 16:24:48 GMT
Subject: Re: [PATCH 1/9] git_config_set: fix off-by-two
Message-ID: <xmqqefk14jlb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <87in9dwsxl.fsf@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> I think if it's worth fixing it's worth testing for, a future change to
> the config code could easily introduce a regression for this, and
> particularly in this type of code obscure edge cases like this can point
> to bugs elsewhere.

Yup.  "The port to my favourite platform is too slow, and everybody
should learn to live with thin test coverage" would not be a good
strategy in the longer run.