From: Junio C Hamano Date: Wed, 20 May 2020 20:23:26 GMT Subject: Re: What's cooking in git.git (May 2020, #07; Wed, 20) Message-ID: In-Reply-To: <20200520200217.GD20332@Carlos-MBP> Carlo Marcelo Arenas Belón writes: > On Wed, May 20, 2020 at 12:17:21PM -0700, Junio C Hamano wrote: >> >> * cb/t4210-illseq-auto-detect (2020-05-18) 2 commits >> - t4210: detect REG_ILLSEQ dynamically and skip affected tests >> - t/helper: teach test-regex to report pattern errors (like REG_ILLSEQ) >> >> As FreeBSD is not the only platform whose regexp library needs >> REG_ILLSEQ prerequisite, add a logic to detect the prerequisite >> automatically. > > since this does no longer use a prerequisite, it might be probably > better to use somethig like : > > As FreeBSD is not the only platform whose regexp library will report > a REG_ILLSEQ error when fed invalid UTF-8, add logic to detect that > automatically and skip the affected tests. Thanks. That does read much better.