From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 09 Apr 2021 22:31:41 GMT
Subject: Re: [PATCH 1/2] blob.c: remove buffer & size arguments to parse_blob_buffer()
Message-ID: <xmqqeefjm6nm.fsf@gitster.g>
In-Reply-To: <YHCUFwZMitOXELpq@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> OK. Calling it parse_blob_buffer() is a little silly since it doesn't
> even take a buffer anymore. But I guess parse_blob() might imply that it
> actually loads the contents from disk to check them (which the other
> parse_foo() functions do), so that's not a good name.

mark_object_as_parsed(), perhaps?

> So this might be the least bad thing. Given that there are only two
> callers, just setting blob->object.parsed might not be unreasonable,
> either. But I don't think it's worth spending too much time on.

Yup.