From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 16 Apr 2021 22:25:07 GMT
Subject: Re: [PATCH] Makefile: add missing dependencies of 'config-list.h'
Message-ID: <xmqqeef9kgu4.fsf@gitster.g>
In-Reply-To: <20210416213356.GR2947267@szeder.dev>

SZEDER Gábor <szeder.dev@gmail.com> writes:

> On Fri, Apr 16, 2021 at 12:03:54PM -0700, Junio C Hamano wrote:
>> SZEDER Gábor <szeder.dev@gmail.com> writes:
>> 
>> > On Thu, Apr 08, 2021 at 07:40:41PM -0400, Jeff King wrote:
>> ...
>> >> I agree it looks like it's moving in the right direction, but I am
>> >> slightly puzzled by the existing code. Why do we need to use $(wildcard)
>> >> for git*.txt, but not for the others?
>> >
>> > We don't need $(wildcard) for git*.txt either, because 'make' expands
>> > wildcards in prerequisites, see e.g.:
>> >
>> >   https://www.gnu.org/software/make/manual/html_node/Wildcard-Examples.html
>> >
>> >
>> > On a related note: all config variables are now listed in
>> > Documentation/config/*.txt; Documentation/*config.txt doesn't contain
>> > any, so that could be removed.
>> 
>> Is it OK for me to keep expecting an update to the patch happen soon?
>
> No, I think this is a good bugfix patch that stands on its own, and
> further cleanups could be done independently on top and should not
> block this patch from being merged to master.

That's fair.

Thanks.