From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 30 Sep 2021 21:45:07 GMT
Subject: Re: [PATCH v6 1/5] difftool: create a tmpdir path without repeated slashes
Message-ID: <xmqqee95agbg.fsf@gitster.g>
In-Reply-To: <20210930170146.61489-1-davvid@gmail.com>

David Aguilar <davvid@gmail.com> writes:

> The paths generated by difftool are passed to user-facing diff tools.
> Using paths with repeated slashes in them is a cosmetic blemish that
> is exposed to users and can be avoided.
>
> Use a strbuf to create the buffer used for the dir-diff tmpdir.
> Strip trailing slashes from the value read from TMPDIR to avoid
> repeated slashes in the generated paths.
>
> Adjust the error handling to avoid leaking strbufs.
>
> Signed-off-by: David Aguilar <davvid@gmail.com>
> ---
> This patch is a resend based off of "next" so that this series can be
> tracked together.
>
> This patch is unchanged since the v5 was submitted, but there are
> new related patches that proceed it.

OK.  I confirmed that this is unchanged from the first step of v5.