From: Junio C Hamano <gitster@pobox.com>
Date: Sun, 28 Aug 2022 06:53:54 GMT
Subject: Re: [PATCH v5 06/16] bisect--helper: make the order consistently `argc, argv`
Message-ID: <xmqqedx0voxp.fsf@gitster.g>
In-Reply-To: <c9dc0281e38bf9bc0bce72de172b5dbadbcbb1f5.1661604264.git.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> From: Johannes Schindelin <johannes.schindelin@gmx.de>
>
> In C, the natural order is for `argc` to come before `argv` by virtue of
> the `main()` function declaring the parameters in precisely that order.
>
> It is confusing & distracting, then, when readers familiar with the C
> language read code where that order is switched around.
>
> Let's just change the order and avoid that type of developer friction.

Thanks.  This did look disturbing to me every time I peeked into
this part of the code.  To some it may be insignificant detail, but
these things add up.  The result is much nicer.