From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 27 Apr 2023 21:52:59 GMT
Subject: Re: [PATCH v2 6/8] fetch: move option related variables into main function
Message-ID: <xmqqedo5hu10.fsf@gitster.g>
In-Reply-To: <cfe84129abe5f93282e1305ec6139fb105481b2e.1682593865.git.ps@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> The options of git-fetch(1) which we pass to `parse_options()` are
> declared globally in `builtin/fetch.c`. This means we're forced to use
> global variables for all the options, which is more likely to cause
> confusion than explicitly passing state around.
>
> Refactor the code to move the options into `cmd_fetch()`. Move variables
> that were previously forced to be declared globally and which are only
> used by `cmd_fetch()` into function-local scope.

Very well done.