From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 24 Jul 2023 18:30:52 GMT
Subject: Re: [PATCH v5 1/1] sequencer: finish parsing the todo list despite an invalid first line
Message-ID: <xmqqedkxp3fn.fsf@gitster.g>
In-Reply-To: <xmqqjzupqn3q.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> The structure of this new test piece, including the use of "log -1
> --format", seems to follow existing tests, and very readable.  Why
> do we have one extra level of subshell, though?  There is no "cd"
> that may affect the later test pieces, and set_something_editor that
> touches environment that may affect the later test pieces is called
> in its own subshell already.
>
> Other than that, looking good (there may be a valid reason why the
> test piece needs the subshell around it, but it was just not apparent
> to me).

Ah, now I notice that Phillip also noticed the same thing.

I just removed the outer subshell while queuing.  Thanks for working
on this, and thanks Phillip for excellent reviews.