From: Junio C Hamano Date: Tue, 24 Oct 2023 17:08:00 GMT Subject: Re: [PATCH v4 4/7] bulk-checkin: implement `SOURCE_INCORE` mode for `bulk_checkin_source` Message-ID: In-Reply-To: Patrick Steinhardt writes: > I'm inclined to agree with your philosophy. Makes me wonder whether we > should write a Coccinelle rule to catch this. But a quick-and-dirty grep > in our codebase shows that such a rule would cause quite a lot of churn: > > $ git grep BUG\( | wc -l > 677 > $ git grep assert\( | wc -l > 549 > > Probably not worth it. Yeah, we can stick to our usual "do not add new instances, fix them while touching near-by code" pattern for this one, I would say. Thanks.