From: Junio C Hamano Date: Fri, 09 Feb 2024 06:31:53 GMT Subject: Re: [PATCH] ref-filter.c: sort formatted dates by byte value Message-ID: In-Reply-To: <5ed018da-2150-42d8-995e-59a35a2e3821@github.com> Victoria Dye writes: > Junio C Hamano wrote: >>> I came across a use case for 'git for-each-ref' at $DAYJOB in which I'd >>> want to sort by a portion of a formatted 'creatordate' (e.g., only the >>> time of day, sans date). When I tried to run something like 'git >>> for-each-ref --sort=creatordate:format:%H:%M:%S', >> >> Hmph, this indeed is interesting ;-) >> >> I wonder if there are other "sort by numeric but the thing could be >> stringified by the end-user" atoms offered by for-each-ref >> machinery. IOW, is the timestamp the only thing that needs this >> fix? > > The only non-FIELD_STR atoms other than the date ones are "objectsize" and > "numparent". "objectsize" has an optional ":disk" modifier, but that doesn't > change formatting (just the value of the integer printed). "numparent" > doesn't have any modifiers, it just prints the integer number of parents. > Otherwise, everything is sorted by string value, so I think only the date > atoms have this kind of mismatch between formatted value and sort value. Thanks.