From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 12 Dec 2025 05:04:58 GMT
Subject: Re: [PATCH 2/2] contrib/coccinelle: pass include paths to spatch(1)
Message-ID: <xmqqecp0cmth.fsf@gitster.g>
In-Reply-To: <aTpieqFoMmZiSzWS@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

>>  # For the 'coccicheck' target
>> -SPATCH_INCLUDE_FLAGS = --all-includes
>> +SPATCH_INCLUDE_FLAGS = --all-includes $(addprefix -I ,compat ewah refs sha256 trace2 win32 xdiff)
>
> This feels weird to me. We never pass any of these includes to the
> compiler, either. So why should Coccinelle require them?
>
> Coming back to your example of `eword_t`, Git knows to always include
> "ewah/ewok.h", and that include is relative to the root directory of Git
> itself. And as the header doesn't have any includes itself, this cannot
> be the root cause, either.
>
> So I'm a bit puzzled why this patch would fix the observed issue.

Indeed it is puzzling..