From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 26 Jan 2026 16:28:28 GMT
Subject: Re: [PATCH 0/3] Small fixups for `OBJECT_INFO` flags
Message-ID: <xmqqecncjq37.fsf@gitster.g>
In-Reply-To: <20260126-b4-pks-read-object-info-flags-v1-0-e682a003b17c@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Surprisingly though I found out that this breaks tests, which of course
> puzzled me. As it turns out though, we were incorrectly using a couple
> of these flags for `odb_has_object()`, and the changed definitions had
> overlap with the existing meaning of other `HAS_OBJECT_*` flags. There
> isn't really any bug here as far as I can see, but this is only really
> by chance.

Great findings.

> In any case, the first two commits fix calls to `odb_has_object()` that
> used invalid flags. The last commit then removes the gaps and converts
> the flags to use an enum instead.

Nice.