From: Junio C Hamano Date: Wed, 15 Apr 2026 15:25:36 GMT Subject: Re: [PATCH 2/2] test-lib-functions: use BUG() in 'test_must_fail' Message-ID: In-Reply-To: <20260414221807.GB3475104@coredump.intra.peff.net> Jeff King writes: > I think the main value of both (but especially test_might_fail) is that > they slot naturally into &&-chains. I left a similar comment in that > other thread, but to expand a bit, if you do: > > false && > true || : && > echo everything ok > > you will get "everything ok", even though step 1 failed. You need: > > false && > { true || : } && > echo everything ok > > except that because it is shell you have to add an extra semicolon after > the ":". ;) > > Syntax-complaints aside, I think it is a very easy thing for > contributors to get wrong. So I think test_might_fail has value, though > I do not care if it has a different name. Yup, I recall that I recently said that I hate that semicolon ;-)