From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 17 Aug 2026 16:53:41 GMT
Subject: Re: [PATCH v13 7/8] history: create squashed commits without editing
Message-ID: <xmqqecfw663u.fsf@gitster.g>
In-Reply-To: <xmqqbjb07osr.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>> It's piped into "tr" to check that
>>
>> 	target = lookup_commit_reference_by_name(s);
>> 	if (target && istarts_with(oid_to_hex(&target->object.oid), s))
>>
>> uses istarts_with() so that we accept uppercase object ids.
>
> You should check in with brian about istarts_with() that is used
> here, as I suspect he missed it in his effort to declare uppercase
> hexadecimal literals invalid.

Ah no, no, no.  This is a new code introduced by this series.

And as I said, I do not see why we want to be case insensitive with
this comparison.