From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 31 Mar 2014 17:14:40 GMT
Subject: Re: [PATCH 1/2] commit: add --ignore-submodules[=<when>] parameter
Message-ID: <xmqqd2h28f3z.fsf@gitster.dls.corp.google.com>
In-Reply-To: <533874F9.3090802@web.de>

Jens Lehmann <Jens.Lehmann@web.de> writes:

>> Changes in add.c and cache.h (and related compilo fix in checkout.c) are
>> needed to make it work for "commit -a" too.
>
> Looking good so far, but we definitely need tests for this new option.
>
> But I wonder if it would make more sense to start by teaching the
> --ignore-submodules option to git add. Then this patch could reuse
> that for commit -a.

I am not sure about the code reuse, but from the usability and
consistency point of view, they must go hand in hand, I would
think.