From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 23 Apr 2014 17:34:30 GMT
Subject: Re: [PATCH v4 2/6] test: add test_write_lines helper
Message-ID: <xmqqd2g80x21.fsf@gitster.dls.corp.google.com>
In-Reply-To: <1398255277-26303-2-git-send-email-mst@redhat.com>

"Michael S. Tsirkin" <mst@redhat.com> writes:

> As suggested by Junio.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---

Ehh, I would probably not suggest such an implementation though.

	test_write_lines () {
		printf "%s\n" "$@"
	}

might be, but not with "echo" and semicolon on the same line as
"for" ;-).

>  t/test-lib-functions.sh | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> index aeae3ca..2fa6453 100644
> --- a/t/test-lib-functions.sh
> +++ b/t/test-lib-functions.sh
> @@ -712,6 +712,13 @@ test_ln_s_add () {
>  	fi
>  }
>  
> +# This function writes out its parameters, one per line
> +test_write_lines () {
> +	for line in "$@"; do
> +		echo "$line"
> +	done
> +}
> +
>  perl () {
>  	command "$PERL_PATH" "$@"
>  }