From: Junio C Hamano Date: Fri, 12 Sep 2014 20:47:42 GMT Subject: Re: [PATCH v21 0/19] rs/ref-transaction (Re: Transaction patch series overview) Message-ID: In-Reply-To: Junio C Hamano writes: > Jonathan Nieder writes: > >> It's "Oops, the next one (refs.c: do not permit err == NULL) is broken, >> and this is to patch it up in advance". :) >> >> But it should apply on top, too. > > I think "in advance" makes sense for this one, too. > >> There were a few other minor changes, and I think with them the series >> should be ready for "next". My "send and hope that more reviewers >> appear" strategy didn't really work,... > > You sent them just a few days ago. Expecting anybody to have a > solid time to sit thru a 19-patch series inside that timeframe is > not so realistic. > >> so I'll send a reroll of the series as-is in an hour or so. > > OK. Thanks. I do not think I have enough time to pick a reroll up to redo the day's integration, so please take time to make it perfect. I noticed that with this series merged to the version I use daily, detaching HEAD (i.e. "git checkout HEAD^0") breaks my HEAD reflog, which made me redo the integration ejecting the series out of 'pu'. Not happy, as my workflow relies fairly heavily on detached HEAD X-<.